mirror/galene
1
Fork 0
mirror of https://github.com/jech/galene.git synced 2024-11-22 16:45:58 +01:00
Code Activity

Don't send NACKs from disk writer.

Browse source 
We're already doing it in the receiver loop.
This commit is contained in:
Juliusz Chroboczek 2022-01-26 02:31:34 +01:00
parent 564dcd4167
commit 1fb4288630
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
diskwriter/diskwriter.go
View file

@ -414,7 +414,7 @@ func (t *diskTrack) Write(buf []byte) (int, error) {
count := p.SequenceNumber - lastSeqno count := p.SequenceNumber - lastSeqno
if count < 256 { if count < 256 {
for i := uint16(1); i < count; i++ { for i := uint16(1); i < count; i++ {
recover(t, lastSeqno+i) fetch(t, lastSeqno+i)
} }
} else { } else {
requestKeyframe(t) requestKeyframe(t)
@ -439,10 +439,10 @@ func (t *diskTrack) Write(buf []byte) (int, error) {
return len(buf), nil return len(buf), nil
} }
func recover(t *diskTrack, seqno uint16) { func fetch(t *diskTrack, seqno uint16) {
// since the samplebuilder retains packets, use a fresh buffer // since the samplebuilder retains packets, use a fresh buffer
buf := make([]byte, 1504) buf := make([]byte, 1504)
n := t.remote.GetPacket(seqno, buf, true) n := t.remote.GetPacket(seqno, buf, false)
if n == 0 { if n == 0 {
return return
} }
@ -462,7 +462,7 @@ func requestKeyframe(t *diskTrack) {
} }
} }
// writeRTP writes the packet without doing any loss recovery. // writeRTP writes the packet without fetching lost packets
// Called locked. // Called locked.
func (t *diskTrack) writeRTP(p *rtp.Packet) error { func (t *diskTrack) writeRTP(p *rtp.Packet) error {
codec := t.remote.Codec().MimeType codec := t.remote.Codec().MimeType