Improve error handling.

client.go

@@ -1215,7 +1215,16 @@ func clientLoop(c *client, conn *websocket.Conn) error {
 				if down != nil {
 					err = negotiate(c, down)
 					if err != nil {
-						return err
+						log.Printf("Negotiate: %v", err)
+						delDownConn(c, down.id)
+						err = failConnection(
+							c, down.id,
+							"negotiation failed",
+						)
+						if err != nil {
+							return err
+						}
+						continue
 					}
 				}
 			case delConnAction:
@@ -1241,14 +1250,11 @@ func clientLoop(c *client, conn *websocket.Conn) error {
 			case connectionFailedAction:
 				found := delUpConn(c, a.id)
 				if found {
-					c.write(clientMessage{
+					err := failConnection(c, a.id,
-						Type:  "error",
+						"ICE said: connection failed")
-						Value: "connection failed",
+					if err != nil {
-					})
+						return err
-					c.write(clientMessage{
+					}
-						Type: "abort",
-						Id:   a.id,
-					})
 					continue
 				}
 				// What should we do if a downstream
@@ -1261,11 +1267,13 @@ func clientLoop(c *client, conn *websocket.Conn) error {
 				if !c.permissions.Present {
 					ids := getUpConns(c)
 					for _, id := range ids {
-						c.write(clientMessage{
+						found := delUpConn(c, id)
-							Type: "abort",
+						if found {
-							Id:   id,
+							failConnection(
-						})
+								c, id,
-						delUpConn(c, id)
+								"permission denied",
+							)
+						}
 					}
 				}
 			case kickAction:
@@ -1292,6 +1300,25 @@ func clientLoop(c *client, conn *websocket.Conn) error {
 	}
 }
 
+func failConnection(c *client, id string, message string) error {
+	if id != "" {
+		err := c.write(clientMessage{
+			Type: "abort",
+			Id:   id,
+		})
+		if err != nil {
+			return err
+		}
+	}
+	if message != "" {
+		err := c.error(userError(message))
+		if err != nil {
+			return err
+		}
+	}
+	return nil
+}
+
 func handleClientMessage(c *client, m clientMessage) error {
 	switch m.Type {
 	case "request":
@@ -1312,7 +1339,8 @@ func handleClientMessage(c *client, m clientMessage) error {
 		}
 		err := gotOffer(c, m.Id, *m.Offer, m.Labels)
 		if err != nil {
-			return err
+			log.Printf("gotOffer: %v", err)
+			return failConnection(c, m.Id, "negotiation failed")
 		}
 	case "answer":
 		if m.Answer == nil {

group.go

@@ -344,7 +344,7 @@ func (c *client) error(err error) error {
 	case userError:
 		return c.write(clientMessage{
 			Type:  "error",
-			Value: "The server said: " + string(e),
+			Value: string(e),
 		})
 	default:
 		return err