mirror of
https://github.com/jech/galene.git
synced 2024-11-22 00:25:58 +01:00
Don't return error when matching empty password.
This avoids displaying "internal server error" when a username is disabled.
This commit is contained in:
parent
e68ff86287
commit
b883171f62
2 changed files with 9 additions and 4 deletions
|
@ -28,7 +28,7 @@ type Password RawPassword
|
|||
func (p Password) Match(pw string) (bool, error) {
|
||||
switch p.Type {
|
||||
case "":
|
||||
return false, errors.New("missing password")
|
||||
return false, nil
|
||||
case "plain":
|
||||
if p.Key == nil {
|
||||
return false, errors.New("missing key")
|
||||
|
|
|
@ -60,10 +60,10 @@ func TestBad(t *testing.T) {
|
|||
if match, err := pw4.Match("bad"); err != nil || match {
|
||||
t.Errorf("pw4 matches")
|
||||
}
|
||||
if match, err := pw5.Match(""); err == nil || match {
|
||||
if match, err := pw5.Match(""); err != nil || match {
|
||||
t.Errorf("pw5 matches")
|
||||
}
|
||||
if match, err := pw5.Match("bad"); err == nil || match {
|
||||
if match, err := pw5.Match("bad"); err != nil || match {
|
||||
t.Errorf("pw5 matches")
|
||||
}
|
||||
if match, err := pw6.Match("bad"); err == nil || match {
|
||||
|
@ -72,12 +72,17 @@ func TestBad(t *testing.T) {
|
|||
}
|
||||
|
||||
func TestEmptyKey(t *testing.T) {
|
||||
for _, tpe := range []string{"", "plain", "pbkdf2", "bcrypt", "bad"} {
|
||||
for _, tpe := range []string{"plain", "pbkdf2", "bcrypt", "bad"} {
|
||||
pw := Password{Type: tpe}
|
||||
if match, err := pw.Match(""); err == nil || match {
|
||||
t.Errorf("empty password of type %v didn't error", tpe)
|
||||
}
|
||||
}
|
||||
|
||||
pw := Password{}
|
||||
if match, err := pw.Match(""); err != nil || match {
|
||||
t.Errorf("empty password empty type matched")
|
||||
}
|
||||
}
|
||||
|
||||
func TestJSON(t *testing.T) {
|
||||
|
|
Loading…
Reference in a new issue