mirror/galene
1
Fork 0
mirror of https://github.com/jech/galene.git synced 2024-11-26 02:25:58 +01:00
Code Activity

Disable simulcast for screen sharing.

Browse source 
Simulcast doesn't seem to work well with screen sharing: only one
layer is sent, which has very low throughput since we send the low
layer first.  Disable simulcast for screen sharing.
This commit is contained in:
Juliusz Chroboczek 2023-01-11 19:36:33 +01:00
parent 3e5545434a
commit bc23b6f489
2 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
static/galene.html
View file

@ -230,9 +230,8 @@
<select id="requestselect" class="select select-inline"> <select id="requestselect" class="select select-inline">
<option value="">nothing</option> <option value="">nothing</option>
<option value="audio">audio only</option> <option value="audio">audio only</option>
<option value="screenshare-low">screen share (low)</option> <option value="screenshare">screenshare only</option>
<option value="screenshare">screen share</option> <option value="everything-low">low quality</option>
<option value="everything-low">everything (low)</option>
<option value="everything" selected>everything</option> <option value="everything" selected>everything</option>
</select> </select>
</form> </form>

5
static/galene.js
View file

@ -607,9 +607,6 @@ function mapRequest(what) {
case 'audio': case 'audio':
return {'': ['audio']}; return {'': ['audio']};
break; break;
case 'screenshare-low':
return {screenshare: ['audio','video-low'], '': ['audio']};
break;
case 'screenshare': case 'screenshare':
return {screenshare: ['audio','video'], '': ['audio']}; return {screenshare: ['audio','video'], '': ['audio']};
break; break;
@ -1227,7 +1224,7 @@ function setUpStream(c, stream) {
let bps = getMaxVideoThroughput(); let bps = getMaxVideoThroughput();
// Firefox doesn't like us setting the RID if we're not // Firefox doesn't like us setting the RID if we're not
// simulcasting. // simulcasting.
if(simulcast) { if(simulcast && c.label !== 'screenshare') {
encodings.push({ encodings.push({
rid: 'h', rid: 'h',
maxBitrate: bps || unlimitedRate, maxBitrate: bps || unlimitedRate,