mirror/galene
1
Fork 0
mirror of https://github.com/jech/galene.git synced 2024-11-26 10:35:59 +01:00
Code Activity

Don't hide mismatches in the PeerConnection state automaton.

Browse source 
The previous behaviour led to silent failures, which was confusing.
This commit is contained in:
Juliusz Chroboczek 2021-02-02 22:57:56 +01:00
parent f4811e8cf5
commit f34ec0ab66
1 changed files with 7 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
rtpconn/webclient.go
View file

@ -569,9 +569,6 @@ func gotAnswer(c *webClient, id string, sdp string) error {
return ErrUnknownId return ErrUnknownId
} }
if down.pc.SignalingState() == webrtc.SignalingStateStable {
log.Printf("Got answer in stable state -- this shouldn't happen")
} else {
err := down.pc.SetRemoteDescription(webrtc.SessionDescription{ err := down.pc.SetRemoteDescription(webrtc.SessionDescription{
Type: webrtc.SDPTypeAnswer, Type: webrtc.SDPTypeAnswer,
SDP: sdp, SDP: sdp,
@ -579,7 +576,6 @@ func gotAnswer(c *webClient, id string, sdp string) error {
if err != nil { if err != nil {
return err return err
} }
}
for _, t := range down.tracks { for _, t := range down.tracks {
local := t.track.Codec() local := t.track.Codec()
@ -590,7 +586,7 @@ func gotAnswer(c *webClient, id string, sdp string) error {
} }
} }
err := down.flushICECandidates() err = down.flushICECandidates()
if err != nil { if err != nil {
log.Printf("ICE: %v", err) log.Printf("ICE: %v", err)
} }