mirror
/
photoview
mirror of https://github.com/photoview/photoview.git
1
Fork 0
Code

Refactor DeleteUser resolver 

- Use tx inside transaction
- Use .Clear() to delete all albums at once,
to prevent unnecessary database hits.
This commit is contained in:
viktorstrate 2021-01-24 17:25:43 +01:00
parent 35344242fa
commit 2d54847fed
No known key found for this signature in database
GPG Key ID: 3F855605109C1E8A
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
api/graphql/resolvers/user.go
View File

@ -215,29 +215,31 @@ func (r *mutationResolver) DeleteUser(ctx context.Context, id int) (*models.User
deletedAlbumIDs := make([]int, 0)
err := r.Database.Transaction(func(tx *gorm.DB) error {
if err := r.Database.First(&user, id).Error; err != nil {
if err := tx.First(&user, id).Error; err != nil {
return err
}
if err := user.FillAlbums(r.Database); err != nil {
userAlbums := user.Albums
if err := tx.Model(&user).Association("Albums").Find(&userAlbums); err != nil {
return err
}
for _, album := range user.Albums {
var associatedUsers = r.Database.Model(album).Association("Owners").Count()
if err := r.Database.Model(&user).Association("Albums").Delete(album); err != nil {
return err
}
if err := tx.Model(&user).Association("Albums").Clear(); err != nil {
return err
}
if associatedUsers == 1 {
for _, album := range userAlbums {
var associatedUsers = tx.Model(album).Association("Owners").Count()
if associatedUsers == 0 {
deletedAlbumIDs = append(deletedAlbumIDs, album.ID)
if dbc := r.Database.Delete(album); dbc.Error != nil {
return dbc.Error
if err := tx.Delete(album).Error; err != nil {
return err
}
}
}
if err := r.Database.Delete(&user).Error; err != nil {
if err := tx.Delete(&user).Error; err != nil {
return err
}